Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #19
Overview
For the first
curta-golf
course, it was possible for solvers to get a block'sPREVRANDAO
value in the same transaction that they submit their solution by usingsubmitDirectly
. Therefore, this PR will deprecate the function in which all solvers will need to use the commit-reveal scheme provided bycommit
+submit
. This is not vulnerable to the above method since any call tosubmit
will check thatblock.timestamp
has been increased by at least60
before calls tosubmit
succeed, ensuring that a solver's call tosubmit
cannot come in the same block as the call tocommit
.Fixes
ICurtaGolf.sol
submitDirectly
function signature.CurtaGolf.sol
submitDirectly
function.CurtaGolf.t.sol
submitDirectly
.test_tokenURI_MintedToken_Succeeds
to usecommit
+submit
.PrintKingArt.s.sol
setUp
has been modified to use thecommit
+submit
method instead ofsubmitDirectly
.RECIPIENT
constant present inPrintParArt.s.sol
and has been added.PrintParArt.s.sol
setUp
has been modified to use thecommit
+submit
method instead ofsubmitDirectly
.