Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving Potential Evaluation Errors #1553

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

MarcusHolly
Copy link
Contributor

@MarcusHolly MarcusHolly commented Jan 30, 2025

Fixes/Resolves:

Issue #1547

Summary/Motivation:

Resolves potential evaluation errors across the repo by removing division from constraints and ensuring that we're taking the log of positive numbers

Changes proposed in this PR:

  • Rewrites various constraints to not use division signs, avoiding potential divisions by 0
  • Adds epsilon values to various constraints to ensure we're taking the log of positive numbers

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly self-assigned this Jan 30, 2025
@lbianchi-lbl lbianchi-lbl added the Priority:Normal Normal Priority Issue or PR label Jan 30, 2025
@lbianchi-lbl
Copy link
Contributor

This PR resolves a lot of warnings that were being emitted by the IDAES diagnostics toolbox and were being ignored until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants