Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

Reuse maxQueueSize from WavefrontSender for spans #32

Open
snicoll opened this issue Apr 24, 2020 · 0 comments
Open

Reuse maxQueueSize from WavefrontSender for spans #32

snicoll opened this issue Apr 24, 2020 · 0 comments
Assignees
@hanwavefront

Comments

@snicoll
Copy link
Collaborator

snicoll commented Apr 24, 2020

There is a TODO in the code that we should fix somehow.

The Spring Boot auto-configuration of the WavefrontSender allows you to specify a custom queue size so perhaps we should reuse that. I didn't do it as reusing the key as is here feels a bit odd. Perhaps there is a way to retrieve that setting or apply it transparently?
@hanwavefront hanwavefront self-assigned this May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hanwavefront hanwavefront

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snicoll @hanwavefront