Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with aligned_allocator in older Eigen version #138

Closed
leokoppel opened this issue Jun 7, 2017 · 0 comments
Closed

Error with aligned_allocator in older Eigen version #138

leokoppel opened this issue Jun 7, 2017 · 0 comments
Assignees
Labels

Comments

@leokoppel
Copy link
Contributor

leokoppel commented Jun 7, 2017

Platform

Trusty with gcc 4.8.4 and Eigen 3.2.0 (as on travis)

Steps to Reproduce

  1. Compile commit 9332d04 on travis

Observed result

Build fails on graph_test.cpp: https://travis-ci.org/wavelab/libwave/builds/240506983

Possible cause

I think it is this bug: http://eigen.tuxfamily.org/bz/show_bug.cgi?id=503

The bug was fixed in Eigen 3.2.1 (http://eigen.tuxfamily.org/index.php?title=ChangeLog#Eigen_3.2.1)

I am temporarily avoiding it by not using aligned_allocator at all (it was only used in a unit test), but this is not a good idea in the long run.

Needed steps

  • See if there is a way to safely and correctly use Eigen in containers, or
  • Increase version requirement of Eigen to one that does not have the bug

Related: #139

@leokoppel leokoppel added the fix label Jun 7, 2017
@leokoppel leokoppel self-assigned this Jun 7, 2017
@leokoppel leokoppel changed the title Ensure correct use of Eigen Error with aligned_allocator in older Eigen version Jun 8, 2017
leokoppel added a commit that referenced this issue Aug 7, 2017
Resolves #193
Resolves #138

This commit reflects external work: I upgraded the ceres-solver and eigen3
packages in the ppa, lkoppel/robotics, to 1.13.0rc1 and 3.3.2, respectively.
They are now being used on travis.

These versions are not actually required for libwave right now, but future
commits will depend on them. These commits will update the required version
number given in find_package(...).  Since the ReadMe lists what we test
against, it can already be updated.
leokoppel added a commit that referenced this issue Aug 7, 2017
* Update Ceres and Eigen versions in ReadMe

Resolves #193
Resolves #138

This commit reflects external work: I upgraded the ceres-solver and eigen3
packages in the ppa, lkoppel/robotics, to 1.13.0rc1 and 3.3.2, respectively.
They are now being used on travis.

These versions are not actually required for libwave right now, but future
commits will depend on them. These commits will update the required version
number given in find_package(...).  Since the ReadMe lists what we test
against, it can already be updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant