-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Eigen and remove dependence on TooN #16
Comments
Should I use Eigen in EKF code? |
Yes, that would be good, assuming it has everything we need? The key would be to properly handle rotation matrices and homogeneous transforms. We want to work in SE(3). Is that possible? TooN was very nice for this, and in the MCPTAM code, it worked well with g2o as a result. I noticed that GTSAM also does SE(3) well, so if Eigen can do that for us, then we are in good shape. If not, you could suggest something else. |
Eigen does not support SE3 calculations out of the box. However there are repos that people have made such as this one that add the support for SE3. https://github.com/strasdat/Sophus |
That could work, code hasn't been touched in three years, so we could pull a copy in as part of mcptam and freeze it. Only issue is that it is not very standard, I don't think. It would remove TooN as a dependency, but require documentation of this SE(3) class. No license issue either. |
Oh I was meaning more of we probably would have to write our own code to do it. We could use this as an example of how to do with Eigen, but ultimately write our own stuff so we know how it works. |
This looks good too: |
No description provided.
The text was updated successfully, but these errors were encountered: