Skip to content

Commit

Permalink
reenable publishing dockerhub images (#159)
Browse files Browse the repository at this point in the history
* Revert "Disable Publishing of images to DockerHub until token issue is addressed (#158)"

This reverts commit 0b0b266.

* Move to personal GH org until the WayfairOSS thing is sorted out
  • Loading branch information
Oded-B authored Apr 3, 2024
1 parent 0b0b266 commit c19c518
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/docker-publish-on-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Log into Docker Hub registry ${{ env.REGISTRY }}
uses: docker/login-action@3d58c274f17dffee475a5520cbe67f0a882c4dbb
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

# Extract metadata (tags, labels) for Docker
# https://github.com/docker/metadata-action
Expand All @@ -70,6 +75,7 @@ jobs:
context: git
images: |
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
odedbenozer/telefonistka
tags: |
type=ref,event=branch
type=ref,event=pr
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Log into Docker Hub registry ${{ env.REGISTRY }}
if: github.event_name != 'pull_request'
uses: docker/login-action@3d58c274f17dffee475a5520cbe67f0a882c4dbb
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

# Extract metadata (tags, labels) for Docker
# https://github.com/docker/metadata-action
Expand All @@ -72,6 +78,7 @@ jobs:
with:
images: |
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
odedbenozer/telefonistka
# Build and push Docker image with Buildx (don't push on PR)
Expand Down

0 comments on commit c19c518

Please sign in to comment.