Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Development] Objective measures #10

Open
vietly23 opened this issue May 24, 2018 · 2 comments
Open

[Development] Objective measures #10

vietly23 opened this issue May 24, 2018 · 2 comments

Comments

@vietly23
Copy link
Contributor

Hi,

I'm going through the redesign document, and there is no mention of scoring functions/objective measures. Should we add an abstract class? I'm picturing the decision process as follows:

boolean AlignerClass::shouldChange() {
    Evaluator scoringFunction = this.getEvaluator(); // Generic scoring class
    Score newScore = scoringFunction.incrementalChange(source, oldTarget, newTarget);
    Score incScore = newScore - oldScore;
    float probability = calculateProbability(score, currentTemperature);
    return (incScore >= 0 or randomReal(gen) <= badProbability);
}

Obviously, the terminology can change, but what should we call the generalized class?

@red4711
Copy link

red4711 commented May 24, 2018

Yes, this would be a great idea. Pasha and I didn't get that far into the design. As far as SANA 2.0 is concerned, we should flesh out our skeleton design before we do any logic implementation.

As for the naming, you could call it something like ObjectiveFunction.

@waynebhayes
Copy link
Owner

waynebhayes commented May 24, 2018 via email

@vietly23 vietly23 mentioned this issue May 30, 2018
utsavjainb pushed a commit to utsavjainb/SANA that referenced this issue Feb 9, 2020
Running version of iterative implementation. Added Edge density comma…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants