-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send shutdown event from the agent to the server #612
Closed
jr0me
wants to merge
24
commits into
main
from
enhancement/585-send-shutdown-event-from-the-agent-to-the-server
Closed
Send shutdown event from the agent to the server #612
jr0me
wants to merge
24
commits into
main
from
enhancement/585-send-shutdown-event-from-the-agent-to-the-server
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
044cb28
to
8c15164
Compare
We can avoid some test set up code repetitions and make it cleaner.
It's clearer and also reduces their scope.
Just for cleaning up some repetition in tests.
Set default expectation on PerformHttpRequest for the authentication and token fetch.
They were not needed.
Replaced raw time_t/int with std::chrono::milliseconds for clarity and type safety. This removes ambiguity in time units, prevents conversion errors, and improves readability. No overhead, as std::chrono::milliseconds is just a strongly-typed integer.
We keep this commit instead of rebasing, so we can easily bring it back once we are ready to enable this feature as well.
First, the matching header file for the source file. Second, includes from the agent. Third, third party libraries. Last, standard c++ includes. This commit also brings timehelper, which is needed to add a timestamp to the shutdown event messages.
8c15164
to
2f6ba71
Compare
Issue is now on hold. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP
Proposed Changes
Results and Evidence
Artifacts Affected
Configuration Changes
Documentation Updates
Tests Introduced
Review Checklist