Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send shutdown event from the agent to the server #612

Conversation

jr0me
Copy link
Member

@jr0me jr0me commented Feb 17, 2025

Description

WIP

Proposed Changes

Results and Evidence

Artifacts Affected

Configuration Changes

Documentation Updates

Tests Introduced

Review Checklist

  • Code changes reviewed
  • Relevant evidence provided
  • Tests cover the new functionality
  • Configuration changes documented
  • Developer documentation reflects the changes
  • Meets requirements and/or definition of done
  • No unresolved dependencies with other issues
  • ...

@jr0me jr0me linked an issue Feb 17, 2025 that may be closed by this pull request
5 tasks
@jr0me jr0me self-assigned this Feb 17, 2025
@jr0me jr0me force-pushed the enhancement/585-send-shutdown-event-from-the-agent-to-the-server branch 3 times, most recently from 044cb28 to 8c15164 Compare February 19, 2025 21:06
jr0me added 24 commits February 20, 2025 11:50
We can avoid some test set up code repetitions and make it
cleaner.
It's clearer and also reduces their scope.
Just for cleaning up some repetition in tests.
Set default expectation on PerformHttpRequest for
the authentication and token fetch.
Replaced raw time_t/int with std::chrono::milliseconds for clarity and type safety.
This removes ambiguity in time units, prevents conversion errors, and improves readability.
No overhead, as std::chrono::milliseconds is just a strongly-typed integer.
We keep this commit instead of rebasing, so
we can easily bring it back once we are ready
to enable this feature as well.
First, the matching header file for the source file.
Second, includes from the agent.
Third, third party libraries.
Last, standard c++ includes.

This commit also brings timehelper, which is needed to
add a timestamp to the shutdown event messages.
@jr0me jr0me force-pushed the enhancement/585-send-shutdown-event-from-the-agent-to-the-server branch from 8c15164 to 2f6ba71 Compare February 20, 2025 17:53
@jr0me
Copy link
Member Author

jr0me commented Feb 21, 2025

Issue is now on hold.

@jr0me jr0me closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send shutdown event from the agent to the server
1 participant