Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should pickling be re-enabled? #116

Open
wbarnha opened this issue Mar 8, 2024 · 0 comments
Open

Should pickling be re-enabled? #116

wbarnha opened this issue Mar 8, 2024 · 0 comments

Comments

@wbarnha
Copy link
Owner

wbarnha commented Mar 8, 2024

dpkp@9740b2b added pickling support.

However, in https://github.com/dpkp/kafka-python/pull/899/files#diff-ec0c29b3ee77321d4150e7578616a894L9, I removed the import, as it appeared to be unused. As a result, the entire file dpkp@9740b2b#diff-74e9dcafb2f9d7443ee297bb5aab1c32 is never used.

So either the import needs to be added back, or the entire file kafka/protocol/pickle.py should be removed.

I haven't spend the time to research how all this works... @dpkp does importing pickle have some silent side-effect that fixes pickling?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wbarnha