cosmetic: eliminate some code warnings

src/test/java/io/wcm/handler/media/impl/MediaHandlerImplAdobeStandardNamingTest.java

@@ -94,6 +94,6 @@ public boolean useAdobeStandardNames() {
       // switch to adobe standard naming
       return true;
     }
-  };
+  }
 
 }

src/test/java/io/wcm/handler/media/impl/MediaHandlerImplTest.java

@@ -326,7 +326,7 @@ public List<Class<? extends MediaProcessor>> getPostProcessors() {
       return List.of(TestPostProcessor.class);
     }
 
-  };
+  }
 
 
   @Model(adaptables = {

src/test/java/io/wcm/handler/media/impl/ipeconfig/CroppingRatiosTest.java

@@ -31,6 +31,7 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
+import org.mockito.Mock.Strictness;
 import org.mockito.junit.jupiter.MockitoExtension;
 
 import io.wcm.handler.media.MediaArgs;
@@ -42,7 +43,7 @@
 @ExtendWith(MockitoExtension.class)
 class CroppingRatiosTest {
 
-  @Mock(lenient = true)
+  @Mock(strictness = Strictness.LENIENT)
   private MediaFormatHandler mediaFormatHandler;
   private SortedSet<MediaFormat> mediaFormats = new TreeSet<>();
 

src/test/java/io/wcm/handler/media/testcontext/DummyAppTemplate.java

@@ -52,11 +52,6 @@ public enum DummyAppTemplate {
     this.resourceType = resourceTypeFromPath;
   }
 
-  DummyAppTemplate(String templatePath, String resourceType) {
-    this.templatePath = templatePath;
-    this.resourceType = resourceType;
-  }
-
   /**
    * Template path
    * @return Path

src/test/java/io/wcm/handler/media/testcontext/DummyMediaHandlerConfig.java

@@ -47,6 +47,7 @@ public class DummyMediaHandlerConfig extends MediaHandlerConfig {
   }
 
   @Override
+  @Deprecated
   public boolean includeAssetWebRenditionsByDefault() {
     // unit tests rely on old behavior
     return true;

src/test/java/io/wcm/handler/mediasource/dam/impl/AssertThumbnailWebRenditionMediaHandlerTest.java

@@ -144,6 +144,7 @@ void testWithAllowSpecificRenditions() {
   void testWithDisallowWebRenditionsViaMediaHandlerConfig() {
     context.registerService(MediaHandlerConfig.class, new MediaHandlerConfig() {
       @Override
+      @Deprecated
       public boolean includeAssetWebRenditionsByDefault() {
         return false;
       }

src/test/java/io/wcm/handler/mediasource/ngdm/impl/metadata/MetadataSample.java

@@ -21,11 +21,14 @@
 
 import static io.wcm.handler.mediasource.ngdm.impl.NextGenDynamicMediaReferenceSample.SAMPLE_ASSET_ID;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 /**
  * Next Gen Dynamic Media Metadata samples.
  */
 public final class MetadataSample {
 
+  @SuppressFBWarnings("HSC_HUGE_SHARED_STRING_CONSTANT")
   public static final String METADATA_JSON_IMAGE = "{"
       + "  \"assetId\": \"" + SAMPLE_ASSET_ID + "\","
       + "  \"repositoryMetadata\": {"