Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalizer does not map paths according to resolver mappings #44

Closed
HitmanInWis opened this issue Jul 16, 2024 · 2 comments · Fixed by #45
Closed

Externalizer does not map paths according to resolver mappings #44

HitmanInWis opened this issue Jul 16, 2024 · 2 comments · Fixed by #45

Comments

@HitmanInWis
Copy link

The Externalizer in AEM Mock does not honor resource resolver mappings, whereas it does on a running AEM server.

As an example if I have a resource resolver mapping of /content/mysite/abc:/custompath

  • Calling resourceResolver.map("/content/mysite/abc/page") returns /custompath/page as expected
  • Calling externalizer.publishLink(resourceResolver, "/content/mysite/abc/page") should return <domain>/custompath/page but instead it returns <domain>/content/mysite/abc/page

This creates a situation where tests have to check for an externalized URL string that is not actually what we expect on the running server.

@stefanseifert
Copy link
Member

implemented with #45

@HitmanInWis
Copy link
Author

Amazing response time :D Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants