Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require odometer readings for partial fills #29

Open
mlv opened this issue Sep 15, 2014 · 1 comment
Open

Don't require odometer readings for partial fills #29

mlv opened this issue Sep 15, 2014 · 1 comment

Comments

@mlv
Copy link

mlv commented Sep 15, 2014

What I'd like is the option to not enter an odometer reading if I'm not filling the tank. Here's an example:

I'm in a hurry and just need a little extra gas. I add a couple gallons, snap a picture of the gas pump, and I'm off. Later, I fill up, and record the odometer. The mileage should be the difference between this full tank's odometer and the last full tank's odometer divided by how much gas I put in this time plus that little splash I did earlier.

It seems to me the mileage should be computed between tankfuls. I can't see what is gained computationally by recording the odometer from just a couple gallons added.

To clarify my suggestion: if I don't check "Tank Full", then don't consider blank an invalid odometer value. It won't be used for computation, so has no real use.

@wdkapps
Copy link
Owner

wdkapps commented Sep 17, 2014

Thank you for the suggestion.

The odometer value for Log entries that are not marked "Tank Full" are used to calculate trip distance for monthly statistics. Omitting these values would skew the stats somewhat, especially for people who don't often fill the tank when adding fuel. More odometer values result in better, more accurate stats. I suppose that making odometer entry optional would allow the user to make the choice based on situation.

There have also been recent suggestions to make entry of price and cost optional (requested by a user that receives free fuel) and fuel quantity optional (for the purpose of recording a note at a given odometer reading)

These are all valid requests that serve valid purposes. The trick will be modifying the Add Fuel UI to allow all of these options while still performing data validation to catch typos and mistakenly omitted values. If we allow every field to be omitted, what validation can we do? Maybe fields can be enabled/disabled by long touch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants