Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't import as expected #23

Open
smithamax opened this issue Feb 21, 2020 · 0 comments · May be fixed by #58
Open

Can't import as expected #23

smithamax opened this issue Feb 21, 2020 · 0 comments · May be fixed by #58

Comments

@smithamax
Copy link

smithamax commented Feb 21, 2020 •
edited
Loading

Having trouble using the package with a simple import as documented

import prom from 'promjs';

Working around it by doing...

import prom from 'promjs/index';

I think this is due to a miss match between the file layout in the git repo vs the published package

package.json refrences lib/index.js

promjs/package.json

Line 5 in dc88ea5

"main": "lib/index.js",

In the package on npm however the actual index.js is in the root of the package, not lib.

I suspect this is due to the cd lib in your push script

promjs/package.json

Line 14 in dc88ea5

"push": "cd lib && npm login && npm publish && git push --set-upstream origin master --follow-tags"

@rbergheim rbergheim linked a pull request Jan 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix path to main rbergheim/promjs
1 participant
@smithamax