Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If .env_AWS_* defined then env.ENABLE_MODULES is ignored #235

Open
RogerSik opened this issue May 15, 2024 · 1 comment
Open

If .env_AWS_* defined then env.ENABLE_MODULES is ignored #235

RogerSik opened this issue May 15, 2024 · 1 comment

Comments

@RogerSik
Copy link

helm value:

          env:
            ENABLE_MODULES: 'backup-s3,text2vec-transformers,qna-transformers'
            BACKUP_S3_BUCKET: 'CHANGE_ME'

argocd diff:

15_09-13-13

If:

          env:
            ENABLE_MODULES: 'backup-s3,text2vec-transformers,qna-transformers'
            BACKUP_S3_BUCKET: 'CHANGE_ME'
            AWS_ACCESS_KEY_ID: 'CHANGE_ME'
            AWS_SECRET_ACCESS_KEY: 'CHANGE_ME'
            AWS_REGION: 'CHANGE_ME'

then

15_09-13-56

Both ENABLE_MODULES value i can confirm with

echo $ENABLE_MODULES 

in the container after deployment. ENABLE_MODULES gets always ignored if one of AWS_
values are defined.

@RogerSik RogerSik changed the title If .env_AWS_* defined than env.ENABLE_MODULES is ignored If .env_AWS_* defined then env.ENABLE_MODULES is ignored May 15, 2024
@RogerSik
Copy link
Author

Found the reason.

If one of

  • env.AWS_ACCESS_KEY_ID
  • env.AWS_SECRET_ACCESS_KEY

is set than env.ENABLE_MODULES is ignored and will be by helm generated. It looks and see

          modules:
            text2vec-transformers:
              enabled: true

            qna-transformers:
              enabled: false

          env:
            ENABLE_MODULES: 'backup-s3,text2vec-transformers,qna-transformers' # <-- this gets ignored

and ignores the ENABLE_MODULES. We have qna-transformers outside of helm deployed because we coulnd't add

spec:
  template:
    spec:
      runtimeClassName: nvidia

to qna-transformers in the helm chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant