Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-rspack): add template-vue-ts #5834

Merged
merged 10 commits into from
May 15, 2024
Merged

feat(create-rspack): add template-vue-ts #5834

merged 10 commits into from
May 15, 2024

Conversation

cnryb
Copy link
Contributor

@cnryb cnryb commented Mar 1, 2024

Summary

Add a template for vue & typescript

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Mar 1, 2024
Copy link

stale bot commented May 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. If this pull request is still relevant, please leave any comment (for example, "bump").

@stale stale bot added the stale label May 3, 2024
@cnryb
Copy link
Contributor Author

cnryb commented May 8, 2024

bump

@stale stale bot removed the stale label May 8, 2024
@chenjiahan
Copy link
Member

Sorry for the late reply, it seems like we are missing this PR.

Can you resolve the conflicts so that we can move this PR forward?

@chenjiahan chenjiahan changed the title feat: add template-vue-ts feat(create-rspack): add template-vue-ts May 8, 2024
Copy link

netlify bot commented May 10, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit c5bdded
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6644b69a67cb130008d7a493

@cnryb cnryb changed the title feat(create-rspack): add template-vue-ts [wip] feat(create-rspack): add template-vue-ts May 10, 2024
@github-actions github-actions bot removed the release: feature release: feature related release(mr only) label May 10, 2024
@cnryb cnryb changed the title [wip] feat(create-rspack): add template-vue-ts feat(create-rspack): add template-vue-ts May 15, 2024
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label May 15, 2024
@cnryb
Copy link
Contributor Author

cnryb commented May 15, 2024

@chenjiahan All comments have been processed, please check

@cnryb cnryb requested a review from chenjiahan May 15, 2024 11:47
chenjiahan
chenjiahan previously approved these changes May 15, 2024
@chenjiahan
Copy link
Member

Thanks for your contribution! ❤️

@chenjiahan chenjiahan enabled auto-merge (squash) May 15, 2024 13:01
@chenjiahan
Copy link
Member

The ESLint CI is failed, please check and fix the import order:

image

https://github.com/web-infra-dev/rspack/actions/runs/9095022005/job/25000876232?pr=5834

auto-merge was automatically disabled May 15, 2024 13:20

Head branch was pushed to by a user without write access

@chenjiahan chenjiahan enabled auto-merge (squash) May 15, 2024 13:22
@chenjiahan chenjiahan merged commit dc02c55 into web-infra-dev:main May 15, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants