fix(rspack_plugin_mf): add chunk js matcher runtime to federation runtime #6434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack canceled.
|
ScriptedAlchemy
force-pushed
the
feat/federation-runtime-js-matcher
branch
from
23e3978 to
f2a5017
Compare
ScriptedAlchemy
commented
May 3, 2024
crates/rspack_plugin_mf/src/container/module_federation_runtime_plugin.rs
Outdated
Show resolved
Hide resolved
|
Could you add a test under |
can do! |
ahabhgk
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exposes internal chunk matcher that is used for ensureChunkHandlers. This allows one to patch js chunk handlers at runtime using the same logic that rspack uses internally. (chunk_matcher.render('chunkid'))
This allows me to reliably implement node federation support without adding a new chunk loading target in rust.
Original implementation: https://github.com/module-federation/core/blob/main/packages/enhanced/src/lib/container/runtime/FederationRuntimeModule.ts#L53
Checklist