Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reject uploads with URLs as "empty" if the URL cannot be fetched #4043

Open
gsnedders opened this issue Oct 9, 2024 · 0 comments
Open
Labels
back-end python Pull requests that update Python code

Comments

@gsnedders
Copy link
Member

c.f. #4020 (comment) in combination with:

p.download(results, screenshots, archives)
if len(p.results) == 0:
_log.error("No results successfully downloaded")
p.update_status(run_id, 'EMPTY', None, callback_url)
return ''

and:

artifact = self._download_http(archive_url)
if artifact is None:
return

and:

except requests.HTTPError:
_log.error("Failed to fetch (%d): %s", r.status_code, url)
return None

While it's technically true that the result set is empty, the fact that it's empty because we failed to download anything is distinctly different to actually receiving no results.

@gsnedders gsnedders added back-end python Pull requests that update Python code labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

1 participant