-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
func BooleanFilterToMods has empty body #22
Comments
That's right can you make a PR for that? I did not have boolean usecase yet so not fully sure how to make working queries for it |
This should probably work not really sure if this is ideal though. It should probably just be a boolean with support for this: #17 (comment) Maybe we should have it more like string filtering or instead of BooleanFIlter just a boolean func BooleanFilterToMods(m *graphql_models.BooleanFilter, column string) []qm.QueryMod {
if m == nil {
return nil
}
var queryMods []qm.QueryMod
if m.IsFalse != nil {
queryMods = append(queryMods, qmhelper.Where(column, qmhelper.EQ, false))
}
if m.IsTrue != nil {
queryMods = append(queryMods, qmhelper.Where(column, qmhelper.EQ, true))
}
if m.IsNull != nil {
queryMods = append(queryMods, qmhelper.Where(column, qmhelper.EQ, nil))
}
return queryMods
} |
The Sample you've provided exactly same what we've ended up with) |
Are you in favor of changing input in scheme to:
|
Yah, sounds good |
Fixed in v2.0.12 |
The text was updated successfully, but these errors were encountered: