Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePickerModal jump wildly when landscape in IOS device #391

Closed
UIT19521334 opened this issue May 22, 2024 · 4 comments
Closed

DatePickerModal jump wildly when landscape in IOS device #391

UIT19521334 opened this issue May 22, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@UIT19521334
Copy link

Current behaviour

The DatePickerModal component jumps wildly when the device is in landscape mode on iOS using react-native-paper-dates.

Expected behaviour

I expect the DatePickerModal component to remain stable and not jump when the device is switched to landscape mode on iOS.

How to reproduce?

  1. Open the app on an iOS device.
  2. Navigate to a screen where the DatePickerModal component is used.
  3. Rotate the device to landscape mode.
  4. Observe the DatePickerModal jumping wildly

Preview

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-05-22.at.16.06.28.mp4

What have you tried so far?

  • Install version 0.22.9
  • wrap in to View have width = deviceWidth

Your Environment

software version
ios 17.4
android x.x.x
react-native 0.73.1
react-native-paper 5.11.6
node 21.7.2
npm or yarn yarn
@UIT19521334 UIT19521334 added the bug Something isn't working label May 22, 2024
@iM-GeeKy
Copy link
Collaborator

iM-GeeKy commented May 22, 2024

@UIT19521334 This appears to be linked to this pull request feel free to try it out and fix the PR if it is a proper solution!

@UIT19521334
Copy link
Author

Thank you, you saved my time. I am very happy to have fixed it in the node module with the following comment. I hope this bug will be fixed in the next version.

@iM-GeeKy
Copy link
Collaborator

Thank you, you saved my time. I am very happy to have fixed it in the node module with the following comment. I hope this bug will be fixed in the next version.

I'll test it and try to get it merged in the next version. Thanks!

@iM-GeeKy
Copy link
Collaborator

simulator_screenshot_5584DDFF-9BDE-450E-B193-CD5EFE6FF09E

@UIT19521334 Did the proposed fix, make the calendar look like this? It seems to fix the jump, but doesn't appear to be fully responsive, so it needs some work still apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants