diff --git a/CHANGELOG.md b/CHANGELOG.md index 0e9e24c..35a6957 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,18 @@ All notable changes to this project will be documented in this file. +## Release 1.4.1 (2022-12-14) + +[Full Changelog](https://github.com/webalexeu/puppet-windows_firewall/compare/v1.4.0...v1.4.1) + +**Features** + +**Bugfixes** + +- [Cannot use 'any' for protocol parameter](https://github.com/webalexeu/puppet-windows_firewall/issues/26) + +**Known Issues** + ## Release 1.4.0 (2022-12-07) [Full Changelog](https://github.com/webalexeu/puppet-windows_firewall/compare/v1.3.4...v1.4.0) @@ -16,6 +28,8 @@ All notable changes to this project will be documented in this file. **Known Issues** +- Cannot use 'any' for protocol parameter + ## Release 1.3.4 (2022-08-23) [Full Changelog](https://github.com/webalexeu/puppet-windows_firewall/compare/v1.3.3...v1.3.4) diff --git a/lib/puppet/type/windows_firewall_rule.rb b/lib/puppet/type/windows_firewall_rule.rb index 95969d3..61e700c 100644 --- a/lib/puppet/type/windows_firewall_rule.rb +++ b/lib/puppet/type/windows_firewall_rule.rb @@ -135,12 +135,15 @@ def insync?(is) newproperty(:protocol) do desc 'the protocol the rule targets' + # Also accept 0-255 :/ - newvalues(:tcp, :udp, :icmpv4, :icmpv6, /^(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$/) + newvalues(:any, :tcp, :udp, :icmpv4, :icmpv6, /^(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$/) isrequired def insync?(is) is.to_s == should.to_s end + + defaultto :any end newproperty(:icmp_type) do diff --git a/metadata.json b/metadata.json index 95bb61a..d2cfc61 100644 --- a/metadata.json +++ b/metadata.json @@ -1,6 +1,6 @@ { "name": "webalex-windows_firewall", - "version": "1.4.0", + "version": "1.4.1", "author": "webalex", "summary": "Manage the windows firewall with Puppet", "license": "Apache-2.0",