Cannot create rule when multiple icmp_type are defined

[Daymarvi]

Hello,

After updating the last puppet module to 1.5.1 i can see that the update of the icmp_type is working
Notice: [100 Allow icmpv4]/Windows_firewall_rule[100 Allow icmpv4]/icmp_type: icmp_type changed ['9', '10', '11'] to ['8', '10', '11'] (corrective)
But not the creation of the rule.
Error: [100 Allow icmpv4]/Windows_firewall_rule[100 Allow icmpv4]/ensure: change from 'absent' to 'present' failed: Execution of 'powershell.exe -ExecutionPolicy Bypass -File C:/ProgramData/PuppetLabs/puppet/cache/lib/ps/windows_firewall/ps-bridge.ps1 create -Name 100 Allow icmpv4 -Enabled True -DisplayName 100 Allow icmpv4 -Direction Inbound -Profile Any -LocalAddress Any -Protocol ICMPv4 -IcmpType 8,10,11 -LocalPort Rpc,Rpcepmap -RemotePort Any -EdgeTraversalPolicy Block -Action Allow -Program any -InterfaceType Any -Service any -Authentication Notrequired -Encryption Notrequired -RemoteMachine any -LocalUser any -RemoteUser any' returned 1: Creating 100 Allow icmpv4 New-NetFirewallRule : The ICMP type/code entry is invalid. When Protocol is ICMPv4 or ICMPv6, type:code pairs are allowed.

When there is a existing rule present for ICMP, the module updating it, but not when a new rule need to be created

In the Update fonction in the ps-bridge.ps1 we have this
if ($IcmpType) { $params.Add("IcmpType", ($IcmpType -split ','))
But it's not the same in the Create function.
if ($IcmpType) { $params.Add("IcmpType", $IcmpType) }

do you want me to do the MR ?
Regards
Alexandre

[webalexeu]

Bug confirmed