Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executable name on Forge builds doesn't take account of packagerConfig #621

Closed
reubenscratton opened this issue Jun 11, 2024 · 3 comments · Fixed by #645
Closed

Executable name on Forge builds doesn't take account of packagerConfig #621

reubenscratton opened this issue Jun 11, 2024 · 3 comments · Fixed by #645
Assignees
Labels
bug Something isn't working electron forge
Milestone

Comments

@reubenscratton
Copy link

application.ts line 52 is:

        darwin: path.join(`${appBuildInfo.appName}.app`, 'Contents', 'MacOS', appBuildInfo.appName),

I believe this should be:

        darwin: path.join(`${appBuildInfo.appName}.app`, 'Contents', 'MacOS', appBuildInfo.config.packagerConfig.executableName),

This change gets me further towards being able to use WebdriverIO with my ElectronJS project, although there is still a way to go. I think there are assumptions about project structure that aren't quite true, e.g. you use EITHER Forge or Builder but never both. But my project uses both - Forge for MacOS and Builder for Windows because of various bugs.

@christian-bromann christian-bromann added bug Something isn't working help wanted Extra attention is needed labels Jun 11, 2024
@goosewobbler
Copy link
Member

@reubenscratton please raise a separate issue for the multiple build tool approach with whatever detail you have around your use case, so that it can be discussed there.

@goosewobbler
Copy link
Member

I'll look at these two after #443 is done.

@goosewobbler goosewobbler added this to the 6.x.y milestone Jun 14, 2024
@goosewobbler goosewobbler removed the help wanted Extra attention is needed label Jun 26, 2024
@goosewobbler goosewobbler changed the title Executable name on MacOS is wrong Executable name on Forge builds doesn't take account of packagerConfig Jun 26, 2024
@goosewobbler goosewobbler modified the milestones: 6.x.y, 7.x.y Jul 9, 2024
@goosewobbler goosewobbler self-assigned this Jul 9, 2024
@goosewobbler goosewobbler modified the milestones: 7.x.y, 7.0.0 Jul 17, 2024
@goosewobbler
Copy link
Member

goosewobbler commented Jul 22, 2024

@reubenscratton This is released in 7.0.0-beta.1. You will need to use the WDIO v9 pre-release with it.

UPDATE: having some issues with the pre-releases, follow #533 for more info
UPDATE: finally released as 7.0.0-beta.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working electron forge
Projects
None yet
3 participants