Bug: I Can't Turn Off or On Anything In The Green Button Menu

[Adamdimoo]

Please Help i Want To Turn Off Sponsor block

[marianmargraf]

+1 on my OLED B7 55

06.10.30
webOS 3.9.2

This issue started at the same time as the other YouTube issue (dark background during playback when UI overlays are toggled)

[jospezial]

@throwaway96 Switches not fixed with https://github.com/webosbrew/youtube-webos/releases/tag/v0.3.5-rc1

[fire332]

Possible duplicate of #157.

Nevermind, this is different.

[fire332]

I can't reproduce this on my C1. Can anybody try out v0.3.5-rc2 and see if it's fixed?

[Informatic]

Just checked v0.3.5-rc.2 on webOS 3.8.0 and seems like we have two issues:

1. On menu open no option is focused and it seems like we need to press up/down a couple of times. I think it would make sense to put focus on first checkbox on options menu open.
2. Enter/OK handling doesn't work because on older chrome evt.isTrusted is always undefined :/ I am not entirely sure of the reasoning behind the check there - is isTrusted set to false on events coming from magic remote cursor? IMO if that's what we want to avoid, we should probably listen to this: https://webostv.developer.lge.com/develop/guides/system-ui-visibility#visibility-of-the-cursor (or alternatively, if that doesn't work for whatever reason - keep a flag that disables OK handling that's turned on in mousemove and disabled in any other key press)

[fire332]

Thanks for the info. I've just added a log right before the isTrusted check and it is only fired once. I'm thinking Youtube changed their ways between then and now.

[fire332]

@throwaway96 this check was added in #143. Do you still remember which version(s) of webOS was this check required for? Or should I just remove it since it seems like it's not necessary anymore from my brief testing on my LG C1?

[fire332]

Also, here's the difference between toggling a checkbox with the enter button (no pointer) vs using the pointer:

I find it interesting how the checkbox is toggled even though isTrusted is false.

[fire332]

I'm thinking I replace the isTrusted check with evt instanceof KeyboardEvent.

[fire332]

Can someone check if the PR fixes their issue on webOS 6.10 as mentioned in #241?

[Informatic]

Firmware 06.10.50 is webOS 3.9.3-63013 (on W17{P,R,M}), so matches what we have here.

[fire332]

Oh, good to know. I thought that version number referred to something else. I'll merge the fix now.

[Informatic]

I'll check this in a minute on my TV.

[Informatic]

Works perfectly, thanks!