Skip to content

Commit

Permalink
Fix a bug about getting callerId
Browse files Browse the repository at this point in the history
:Release Notes:
Fix a bug about getting callerId

:Detailed Notes:
SAM gets callers' ID by using LS2 interface.
Normally, it should be one of below items.

1. application
2. service

However, sometimes, it is null.
This commit checks returnValue from those APIs
and assign 'unknown' if there is nothing.

:Testing Performed:
- network disconnect
- launch youtube
- click 'NETWORK SETTINGS'
- Settings works well

:Issues Addressed:
[PLAT-102158] [webOS Auto]:Network Connection Error page
              functionality is not working

Change-Id: Ief321c97e43b88e1e7a89ff578eb06e4157ef5cd
Reviewed-on: http://gpro.lge.com/c/webosose/sam/+/271209
Tested-by: Sangwoo Kang <[email protected]>
Reviewed-by: Sangwoo Kang <[email protected]>
  • Loading branch information
sangwoo-kang committed Mar 16, 2020
1 parent 545d696 commit 016dd3a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/base/LunaTask.h
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,10 @@ friend class LunaTaskList;
{
if (m_request.getApplicationID() != nullptr) {
return m_request.getApplicationID();
} else {
} else if (m_request.getSenderServiceName() != nullptr){
return m_request.getSenderServiceName();
} else {
return "unknown";
}
}

Expand Down

0 comments on commit 016dd3a

Please sign in to comment.