Stylelint plugin - fix issue where "customSyntax" property is not rec…

…ognised as a resolved dependency (#802)
webpro-nl · Oct 4, 2024 · fdb0246 · fdb0246
1 parent d9ae5dc
commit fdb0246
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/packages/knip/fixtures/plugins/stylelint/.stylelintrc b/packages/knip/fixtures/plugins/stylelint/.stylelintrc
@@ -1,4 +1,5 @@
 {
+  "customSyntax": "postcss-less",
   "extends": ["stylelint-config-standard", "./myExtendableConfig"],
   "plugins": ["stylelint-order"],
   "rules": {

diff --git a/packages/knip/src/plugins/stylelint/index.ts b/packages/knip/src/plugins/stylelint/index.ts
@@ -14,10 +14,11 @@ const isEnabled: IsPluginEnabled = ({ dependencies }) => hasDependency(dependenc
 const config = ['package.json', ...toCosmiconfig('stylelint')];
 
 const resolve = (config: StyleLintConfig | BaseStyleLintConfig): string[] => {
-  const extend = config.extends ? [config.extends].flat().filter(id => !isInternal(id)) : [];
-  const plugins = config.plugins ? [config.plugins].flat().filter(id => !isInternal(id)) : [];
+  const extend = config.extends ? [config.extends].flat() : [];
+  const plugins = config.plugins ? [config.plugins].flat() : [];
+  const customSyntax = config.customSyntax ? [config.customSyntax] : [];
   const overrideConfigs = 'overrides' in config ? config.overrides.flatMap(resolve) : [];
-  return [...extend, ...plugins, ...overrideConfigs];
+  return [...extend, ...plugins, ...overrideConfigs, ...customSyntax].filter(id => !isInternal(id));
 };
 
 const resolveConfig: ResolveConfig<StyleLintConfig> = config => resolve(config);

diff --git a/packages/knip/src/plugins/stylelint/types.ts b/packages/knip/src/plugins/stylelint/types.ts
@@ -1,4 +1,5 @@
 export type BaseStyleLintConfig = {
+  customSyntax?: string;
   extends?: string | string[];
   plugins?: string[];
 };

diff --git a/packages/knip/test/plugins/stylelint.test.ts b/packages/knip/test/plugins/stylelint.test.ts
@@ -14,14 +14,15 @@ test('Find dependencies with the stylelint plugin', async () => {
   });
 
   assert(issues.devDependencies['package.json']['stylelint']);
+  assert(issues.unlisted['.stylelintrc']['postcss-less']);
   assert(issues.unlisted['.stylelintrc']['stylelint-config-standard']);
   assert(issues.unlisted['.stylelintrc']['stylelint-order']);
   assert(issues.unlisted['.stylelintrc']['stylelint-config-html/html']);
 
   assert.deepEqual(counters, {
     ...baseCounters,
     devDependencies: 1,
-    unlisted: 3,
+    unlisted: 4,
     processed: 0,
     total: 0,
   });