Add graphql-codegen support #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, happy to merge this one when it's finished, almost there I guess!
Sorry about that, will update plugin template & docs. Just pushed a commit: plugins need the |
webpro
approved these changes
Oct 23, 2023
|
And this should now be all good ! |
|
Thanks, Nicolas! Again, great work, I really appreciate everything you do for Knip 🙏 |
|
🚀 This pull request is included in v2.38.0. See Release 2.38.0 for release notes. |
|
❤️ this is amazing, thanks for adding it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce support for Graphql-codegen to knip.
This inclues all the different config format, all with types coming from the lib itself to ensure we are reading the correct values.
I'v added
However, I have a small issue, for some reason, the plugin won't read package.json, I have to figure out why