Rewrite fix 3.7.6 (#144)

- deproxy assignment to TreeWalker.currentNode
- ensure generic attributes (src and href) are not rewritten on custom web-component elements (elements that contain a '-')
- add nop override for navigator.getInstalledRelatedApps() if it is defined
- Proxy defineProperty: don't pull in value from object if either getter or setter are provided
- bump to 3.7.6

Author: ikreymer

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webrecorder/wombat",
-  "version": "3.7.5",
+  "version": "3.7.6",
   "main": "index.js",
   "license": "AGPL-3.0-or-later",
   "author": "Ilya Kreymer, Webrecorder Software",

src/wombat.js

@@ -2010,7 +2010,7 @@ Wombat.prototype.performAttributeRewrite = function(
  */
 Wombat.prototype.rewriteAttr = function(elem, name, absUrlOnly) {
   var changed = false;
-  if (!elem || !elem.getAttribute || elem._no_rewrite || elem['_' + name]) {
+  if (!elem || !elem.getAttribute || elem._no_rewrite || elem['_' + name] || (elem.tagName && elem.tagName.indexOf('-') > 0)) {
     return changed;
   }
 
@@ -3007,6 +3007,26 @@ Wombat.prototype.overridePropExtract = function(proto, prop) {
   }
 };
 
+/**
+ * Applies an attribute setter override to de-proxy the prop
+ * @param {Object} proto
+ * @param {string} prop
+ * @param {*} [cond]
+ */
+Wombat.prototype.overrideDeProxyPropAssign = function(proto, prop) {
+  var orig_setter = this.getOrigSetter(proto, prop);
+  var orig_getter = this.getOrigGetter(proto, prop);
+  var wombat = this;
+  if (orig_setter) {
+    var new_setter = function (value) {
+      return orig_setter.call(wombat.proxyToObj(this), wombat.proxyToObj(value));
+    };
+    this.defProp(proto, prop, new_setter, orig_getter);
+  }
+};
+
+
+
 
 /**
  * Overrides referrer -- if top-replay frame, referrer should be "", otherwise extractOriginURL
@@ -5954,6 +5974,9 @@ Wombat.prototype.initMiscNavigatorOverrides = function() {
   if (this.$wbwindow.navigator.mediaDevices) {
     this.$wbwindow.navigator.mediaDevices.setCaptureHandleConfig = function() {};
   }
+  if (this.$wbwindow.navigator.getInstalledRelatedApps) {
+    this.$wbwindow.navigator.getInstalledRelatedApps = function() { return Promise.resolve([]); };
+  }
 };
 
 
@@ -6280,7 +6303,7 @@ Wombat.prototype.initWindowObjProxy = function($wbwindow) {
       },
       defineProperty: function(target, prop, desc) {
         var ndesc = desc || {};
-        if (ndesc.value === undefined && ndesc.get === undefined) {
+        if (!ndesc.hasOwnProperty('value') && !ndesc.hasOwnProperty('get') && !ndesc.hasOwnProperty('set')) {
           ndesc.value = $wbwindow[prop];
         }
         Reflect.defineProperty($wbwindow, prop, ndesc);
@@ -6777,6 +6800,8 @@ Wombat.prototype.wombatInit = function() {
     'dispatchEvent'
   );
 
+  this.overrideDeProxyPropAssign(this.$wbwindow.TreeWalker.prototype, 'currentNode');
+
   this.initTimeoutIntervalOverrides();
 
   this.overrideFramesAccess(this.$wbwindow);