New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource: custom dir prefix generator for generateSavePath #731

Open

myfreeer opened this issue Jan 15, 2023 · 3 comments

Labels

Member

myfreeer commented Jan 15, 2023

Map different host and path to different savePath
https://github.com/website-local/website-scrap-engine/blob/0.5.0/src/resource.ts#L309-L327

myfreeer added the enhancement label

Member Author

myfreeer commented Feb 26, 2023

This should be marked as BREAKING change, and generateSavePath could be a seperate life cycle.

Member Author

myfreeer commented Feb 28, 2023

Also we can make createResource api more like the other life-cycles.

Member Author

myfreeer commented Mar 8, 2023

A wrapper should be made to help users to migrate to new api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment