Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share link for marketplace submissions isn't communicated well #4424

Open
kof opened this issue Nov 15, 2024 · 5 comments
Open

Share link for marketplace submissions isn't communicated well #4424

kof opened this issue Nov 15, 2024 · 5 comments
Labels
area:marketplace complexity:low Good for newcomers, up to a few days of work prio:2 Always look for prio:1 issues first before working on prio:2 type:feat Features and enhancements

Comments

@kof
Copy link
Member

kof commented Nov 15, 2024

When a designer submits a project to the marketplace, they don't know they have to create a share link with view permissions for the project to have a link for viewing, otherwise the link will be disabled

image
@kof kof added prio:2 Always look for prio:1 issues first before working on prio:2 complexity:low Good for newcomers, up to a few days of work area:marketplace type:feat Features and enhancements labels Nov 15, 2024
@natapokie
Copy link

Hello! I'm a first-time contributor, and I'm interested in taking a look at this issue. My initial thought is to maybe create a share link with view permissions for the project by default. Could you provide more details on how to navigate this? And any tips on improving the share link would be appreciated!

@kof
Copy link
Member Author

kof commented Nov 18, 2024

Not sure. If we create one the same way user creates them, its going to be in the list without explicitely telling user why it's there. Potentially we would need a special link that is either not shown in the share dialog or is shown but rendered in a special way with a tooltip that communicates what it is and that it can't be deleted if project is in the marketplace. Maybe it makes sense to not show it at all there.

@natapokie
Copy link

Hi @kof ! I was thinking about some other solutions, and I wanted to get your thoughts on some ideas below,

  1. Similar to what you mentioned, maybe we can hide the "Open project" button, and display a message near it letting other users know to contact the author so they can view the project as a separate link. There are two options for this approach, we can hide the Open project button or keep it there,
    Slice 1 (1)
    Slice 1 (2)

  2. Generally I think we should use 1. and 2. together, I think it would be helpful for users that are submitting to the Marketplace to have an option to automatically create a share link -- maybe a checkbox?
    Slice 2

Additionally, I noticed that there is already a tooltip that indicates the reason for the disabled button, perhaps we can make the message more descriptive if the other options above aren't possible?
image

Let me know what you think, thanks!

@kof
Copy link
Member Author

kof commented Nov 20, 2024

I still think that the share link should be just generated always by default and not showed in the share dialog at all or show it so it can be copied but make it non-deleatable and renamable.

@natapokie
Copy link

I see, thank you for the clarification! I'll begin working on generating the share link by default when you upload a project to the marketplace, and we can decide later whether to show/hide the marketplace link in the share dialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:marketplace complexity:low Good for newcomers, up to a few days of work prio:2 Always look for prio:1 issues first before working on prio:2 type:feat Features and enhancements
Projects
None yet
Development

No branches or pull requests

2 participants