Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple commands on the same hook overwrite each other #39

Open
morganestes opened this issue Jul 17, 2015 · 8 comments
Open

Multiple commands on the same hook overwrite each other #39

morganestes opened this issue Jul 17, 2015 · 8 comments

Comments

@morganestes
Copy link

With v0.3.1: I've tried to add multiple commands to a single hook, but they get overwritten and only the last one survives. Specifically, I'm trying to get npm, Composer, and Bower to all update on the same hook, then have Grunt run, but each one overwrites the hook file and I'm only left with the Grunt command.

Here's an example of what I'm trying to do:

githooks: {
    'all': {
        'pre-commit': 'css js'
    },
    'dev.composer': {
        'post-merge': {
            command: 'composer',
            taskNames: 'update'
        },
        'post-checkout': {
            command: 'composer',
            taskNames: 'update'
        }
    },
    'dev.node': {
        'post-merge': {
            command: 'npm',
            taskNames: 'update'
        },
        'post-checkout': {
            command: 'npm',
            taskNames: 'update'
        }
    },
    'dev.bower': {
        'post-merge': {
            command: 'bower',
            taskNames: 'install update'
        },
        'post-checkout': {
            command: 'bower',
            taskNames: 'install update'
        }
    },
    'dev.grunt': {
        'post-merge': 'default',
        'post-checkout': 'default'
    }
},
@franz-josef-kaiser
Copy link
Member

@morganestes Do you have a PR for us?

@morganestes
Copy link
Author

@franz-josef-kaiser Not yet. I haven't figured out a fix for it, but I wanted to open an issue for reference even though I don't have a fix.

@franz-josef-kaiser
Copy link
Member

That's ok. It will stay open until someone has time (and a solution). If it's open in a month or so, I'll clean up and close the issue.

@franz-josef-kaiser franz-josef-kaiser modified the milestones: Backlog, 0.4.0 Jul 20, 2015
@franz-josef-kaiser franz-josef-kaiser modified the milestones: 0.6.0, Backlog Oct 11, 2015
@franz-josef-kaiser
Copy link
Member

@morganestes Still open. Do you want to contribute and work on this one?

@morganestes
Copy link
Author

Sorry, it's been on my list but I haven't had a chance to look at it yet. I do still want to work on it, but understand if you don't want long-running issues open.

@franz-josef-kaiser
Copy link
Member

@morganestes I will just ping you from time to time. No problem with open issues.

@franz-josef-kaiser
Copy link
Member

@morganestes FYI I added this to the backlog for 0.6.0 – every time I read it, I like this idea more and more.

@franz-josef-kaiser franz-josef-kaiser modified the milestones: Backlog, 0.6.0 Apr 10, 2016
@franz-josef-kaiser
Copy link
Member

@morganestes because it's this time of the year :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants