From e4be522a48e3c27655aca320be66b226d793fa0d Mon Sep 17 00:00:00 2001 From: idipanshu <105773536+idipanshu@users.noreply.github.com> Date: Tue, 12 Dec 2023 16:42:24 +0530 Subject: [PATCH 1/4] feat: add glue container in CI --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0a41085..6eb198c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,6 +9,8 @@ on: jobs: run-ci: runs-on: ubuntu-latest + container: + image: dipanshuwed/glue3.0 steps: - name: Checkout repository uses: actions/checkout@v3 From 3de2a0054d515905bf63a68f58c960d7c3d0fec1 Mon Sep 17 00:00:00 2001 From: idipanshu <105773536+idipanshu@users.noreply.github.com> Date: Tue, 12 Dec 2023 16:48:09 +0530 Subject: [PATCH 2/4] chore: remove setup python; use python provided in container --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6eb198c..1d4a4cc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,10 +15,10 @@ jobs: - name: Checkout repository uses: actions/checkout@v3 - - name: Set up Python - uses: actions/setup-python@v2 - with: - python-version: 3.10.12 + #- name: Set up Python + #uses: actions/setup-python@v2 + #with: + #python-version: 3.10.12 - name: Install dependencies run: | From 28872017bb28b459f4a2db1247749725f785ea72 Mon Sep 17 00:00:00 2001 From: idipanshu <105773536+idipanshu@users.noreply.github.com> Date: Tue, 12 Dec 2023 19:08:11 +0530 Subject: [PATCH 3/4] feat: update glue image version 3.0 => 4.0 --- .github/workflows/ci.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1d4a4cc..981e048 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,19 +10,14 @@ jobs: run-ci: runs-on: ubuntu-latest container: - image: dipanshuwed/glue3.0 + image: dipanshuwed/glue4.0 steps: - name: Checkout repository uses: actions/checkout@v3 - #- name: Set up Python - #uses: actions/setup-python@v2 - #with: - #python-version: 3.10.12 - - name: Install dependencies run: | - pip install mypy==1.7.1 pylint==3.0.2 pyspark==3.3.0 coverage + pip3 install mypy pylint coverage - name: Type check run: mypy ./ --ignore-missing-imports From f9b46318f4ae148e2388e94de9bab9bcaeb06b47 Mon Sep 17 00:00:00 2001 From: idipanshu <105773536+idipanshu@users.noreply.github.com> Date: Tue, 12 Dec 2023 22:33:56 +0530 Subject: [PATCH 4/4] feat: add jq for sonar cloud --- .github/workflows/ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 981e048..eeb09a0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,6 +18,7 @@ jobs: - name: Install dependencies run: | pip3 install mypy pylint coverage + yum install jq -y # jq is required for sonar - name: Type check run: mypy ./ --ignore-missing-imports @@ -29,7 +30,9 @@ jobs: run: coverage run --source=app -m unittest discover -s app/tests/ - name: Test coverage report - run: coverage xml + run: | + coverage report + coverage xml - name: SonarQube Scan uses: sonarsource/sonarqube-scan-action@master