Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom image doesn't seem to be fetched anymore #362

Closed
ramnes opened this issue Oct 3, 2024 · 3 comments
Closed

Custom image doesn't seem to be fetched anymore #362

ramnes opened this issue Oct 3, 2024 · 3 comments

Comments

@ramnes
Copy link

ramnes commented Oct 3, 2024

Hey, thanks for the nice project!

The banner on the README of this project used to have a MongoDB logo in there, but it doesn't have it anymore: https://github.com/Refty/mongo-thingy

I thought it may be due to a rate limit on imgur's side, so I tried by hosting the image elsewhere, but it didn't help.

@KemingHe
Copy link
Collaborator

KemingHe commented Dec 4, 2024

Hi @ramnes , I'm Keming, a major maintainer of Socialify. Grateful for your usage. Have you considered the solution mentioned in #406 ? IMO this is much simpler and more permanent given that your logo/branding and code are now managed together.

Let me know if you have any other questions. Happy to help! 🌻

@wei
Copy link
Owner

wei commented Dec 11, 2024

Hi @ramnes thanks for opening the issue, sorry I missed it earlier.

At this time, we clearly state in the app that we require an SVG logo url or data uri. PNG/JPG tends to be large and we intentionally do not support them. They just happen to work at the moment but it is not a supported feature and can be removed at any time.

I recommend using the official svg which tends to be smaller and more cripsp: https://www.mongodb.com/company/newsroom/brand-resources

I grabbed one here:

https://socialify.git.ci/Refty/mongo-thingy/image?font=Bitter&language=1&logo=data%3Aimage%2Fsvg%2Bxml%2C%253Csvg%2520xmlns%253D%2522http%253A%252F%252Fwww.w3.org%252F2000%252Fsvg%2522%2520viewBox%253D%25220%25200%25201024%25201024%2522%253E%253Cdefs%253E%253Cstyle%253E.a%257Bfill%253A%252300684a%253B%257D%253C%252Fstyle%253E%253C%252Fdefs%253E%253Ctitle%253EMongoDB%253C%252Ftitle%253E%253Cpath%2520class%253D%2522a%2522%2520d%253D%2522M600.5%252C118.86C557.8%252C68.41%252C521%252C17.18%252C513.51%252C6.54a1.92%252C1.92%252C0%252C0%252C0-2.77%252C0c-7.51%252C10.64-44.29%252C61.87-87%252C112.32C57.19%252C584.3%252C481.48%252C898.4%252C481.48%252C898.4l3.56%252C2.37C488.2%252C949.24%252C496.11%252C1019%252C496.11%252C1019h31.63s7.91-69.36%252C11.08-118.23l3.55-2.76C542.77%252C898%252C967.06%252C584.3%252C600.5%252C118.86ZM511.93%252C891.31s-19-16.16-24.12-24.44v-.78l22.93-506.83a1.19%252C1.19%252C0%252C0%252C1%252C2.37%252C0l22.94%252C506.83v.78C530.91%252C875.15%252C511.93%252C891.31%252C511.93%252C891.31Z%2522%252F%253E%253C%252Fsvg%253E&owner=1&pattern=Charlie%20Brown&theme=Light

Edit Link

@wei wei closed this as completed Dec 11, 2024
@ramnes
Copy link
Author

ramnes commented Dec 11, 2024

Makes sense. Thanks for the link!

If I may, I'd recommend disabling other formats than SVG explicitly. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants