Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable - search prop of column is useless, rework to allow proper custom search. #48

Open
jpfisher72 opened this issue Dec 5, 2024 · 0 comments
Assignees
Labels
DataTable enhancement New feature or request

Comments

@jpfisher72
Copy link
Member

jpfisher72 commented Dec 5, 2024

Currently the search prop is used to manually pass/fail a row's column when searching. Not super useful.

search?: (row: T) => boolean

should be instead:

search?: (row: T, search: string) => boolean

This would allow you to actually compare the row to the search string for a given column to determine if it should pass the search for that column.

This also is probably more appropriate as a prop of the DataTable, not an individual column

@jpfisher72 jpfisher72 added enhancement New feature or request DataTable labels Dec 5, 2024
@jpfisher72 jpfisher72 self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataTable enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant