-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As people are added, the site is becoming sluggish and slow to load #579
Comments
How is it slow? Scrolling? Images loading? rendering? |
Using Firefox, these are the network stats I got:
A lot of the request were avatar URLs - these could possibly be minimised by only loading when they're in the viewport. Filtering is also extremely slow for me but that could be due to my system (dual core i3). |
Yeah almost all of that is image requests. I'll add lazy loading, looks like it will be added to firefox soon so its a good solution. Filtering does have a few MS of lag for me too. Likely in the React render. Anyone want to take a look at this? |
You can tell the lag is in the render because when we filter for small numbers, it's fast. I bet we can just hide people instead of re-rendering each time. Let me try that.. |
I goofed around with it for a bit yesterday but I don't think hiding it is the issue.. If anyone is good ith the profiler on react dev tools, please take a look. It very clearly shows that the render for the large tags( 150+ people) takes ~300ms which is way too long |
This, from your link, looks incredibly promising, and I don't see it being too difficult to implement. Seems like it'll just take a few lines. I'll play around. |
Or maybe infinite pagination can be added. |
I think the easiest (potential) fix would be to apply |
Not sure what could be done about this but I've just noticed it. With the amount of people who are in the list now, the website loads up quite slowly.
Could lazy-loading be implemented somehow?
The text was updated successfully, but these errors were encountered: