-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use canvas instead of a table for each field #21
Comments
This PR changes the field rendering to use canvas instead of a table. It basically adds a `draw-square` and triggers the rendering when the component mounts. Closes weslleyaraujo#21.
@weslleyaraujo shall we work on this again? |
for sure @rafaelrinaldi <3 |
@weslleyaraujo Do you remember what was wrong with my previous implementation? Please, give me a background then I can pick up from where I left it. |
As far as I remember there were a bug whenever you clicked on a item the action Id was different from expected.. and it was happening like in the second level and sometimes in the first. you can track the id at: https://github.com/weslleyaraujo/react-flux-puzzle/blob/master/src/assets/js/actions/match.js |
@rafaelrinaldi just did an awesome example of an implementation of the fields using canvas!
https://jsbin.com/govise/edit?js,output
a PR would be awesome 😏
The text was updated successfully, but these errors were encountered: