Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use canvas instead of a table for each field #21

Open
weslleyaraujo opened this issue Nov 5, 2015 · 4 comments
Open

Use canvas instead of a table for each field #21

weslleyaraujo opened this issue Nov 5, 2015 · 4 comments

Comments

@weslleyaraujo
Copy link
Owner

@rafaelrinaldi just did an awesome example of an implementation of the fields using canvas!

https://jsbin.com/govise/edit?js,output

a PR would be awesome 😏

rafaelrinaldi added a commit to rafaelrinaldi/react-flux-puzzle that referenced this issue Nov 6, 2015
This PR changes the field rendering to use canvas instead of a table.

It basically adds a `draw-square` and triggers the rendering when the component mounts.

Closes weslleyaraujo#21.
@rafaelrinaldi
Copy link
Contributor

@weslleyaraujo shall we work on this again?

@weslleyaraujo
Copy link
Owner Author

for sure @rafaelrinaldi <3

@rafaelrinaldi
Copy link
Contributor

@weslleyaraujo Do you remember what was wrong with my previous implementation? Please, give me a background then I can pick up from where I left it.

@weslleyaraujo
Copy link
Owner Author

As far as I remember there were a bug whenever you clicked on a item the action Id was different from expected.. and it was happening like in the second level and sometimes in the first.

you can track the id at: https://github.com/weslleyaraujo/react-flux-puzzle/blob/master/src/assets/js/actions/match.js

@weslleyaraujo weslleyaraujo reopened this Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants