-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logo.svg missing? #156
Comments
The file is not missing, it's the actual page that is incorrect and should not be used. |
Can I get a citation on that? What if it's an intranet application... don't they have splash pages? |
sorry, the file I meant was logo.svg. apologies for the typo |
@RobJohnston no. The demos have a sample splash page to be used. The file that reference the logo.svg is a residual file carried over from the core repo |
The file I am referring to is splashpage-en.html from the themes-dist-4.0.20-theme-gc-intranet folder. It contains the logo.svg. Is there a different splashpage I should be using? |
Hmmm. I guess the splash page was never implemented for this theme |
The file I'm looking at came with the download of the theme for 4.0.20. When you say it wasn't implemented for this theme, does that mean what I found is not valid? |
It is using the splash markup from the WET theme so it's not specific to this theme no |
Do you know if that is normal/intended or if this was an oversite that might be updated at some point? This is the theme I have to use in the next upgrade to our project so I need to be clear on the details. |
It probably should be update to somewhat resemble the GCWU theme |
Is there something I should be doing to request this splash page? |
I don't know who maintains this theme now /cc @shawnthompson |
In the intranet theme, the splashpage code includes a reference to a log.svg file that seems to not be in the assets folder that it refers to - is that missing or is that deliberate?
The text was updated successfully, but these errors were encountered: