Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logo.svg missing? #156

Open
regio760 opened this issue Apr 13, 2016 · 12 comments
Open

logo.svg missing? #156

regio760 opened this issue Apr 13, 2016 · 12 comments

Comments

@regio760
Copy link

In the intranet theme, the splashpage code includes a reference to a log.svg file that seems to not be in the assets folder that it refers to - is that missing or is that deliberate?

@LaurentGoderre
Copy link
Member

The file is not missing, it's the actual page that is incorrect and should not be used.

@RobJohnston
Copy link

Can I get a citation on that? What if it's an intranet application... don't they have splash pages?

@regio760
Copy link
Author

sorry, the file I meant was logo.svg. apologies for the typo

@LaurentGoderre
Copy link
Member

@RobJohnston no. The demos have a sample splash page to be used. The file that reference the logo.svg is a residual file carried over from the core repo

@regio760
Copy link
Author

The file I am referring to is splashpage-en.html from the themes-dist-4.0.20-theme-gc-intranet folder. It contains the logo.svg. Is there a different splashpage I should be using?

@LaurentGoderre
Copy link
Member

Hmmm. I guess the splash page was never implemented for this theme

@regio760
Copy link
Author

The file I'm looking at came with the download of the theme for 4.0.20. When you say it wasn't implemented for this theme, does that mean what I found is not valid?

@LaurentGoderre
Copy link
Member

It is using the splash markup from the WET theme so it's not specific to this theme no

@regio760
Copy link
Author

Do you know if that is normal/intended or if this was an oversite that might be updated at some point? This is the theme I have to use in the next upgrade to our project so I need to be clear on the details.

@LaurentGoderre
Copy link
Member

It probably should be update to somewhat resemble the GCWU theme

@regio760
Copy link
Author

Is there something I should be doing to request this splash page?

@LaurentGoderre
Copy link
Member

LaurentGoderre commented Apr 20, 2016

I don't know who maintains this theme now /cc @shawnthompson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants