Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please tag v4.0 branch #183

Open
kngai opened this issue Dec 17, 2015 · 2 comments
Open

Please tag v4.0 branch #183

kngai opened this issue Dec 17, 2015 · 2 comments

Comments

@kngai
Copy link
Contributor

kngai commented Dec 17, 2015

Hi @upsonp,

There are a lot of fixes and development going on in the v4.0 branch, which is excellent and all. However we're actually using this branch as a dep for some of our operational projects and the latest Dec, 2015 merges have been breaking our builds. In hindsight, I should of forked and tag it accordingly for myself.

Can you perhaps create a tag (4.0.0 perhaps) for this build of the v4 branch: https://github.com/wet-boew/wet-boew-php/tree/d2d1d993da86b9aa1b2afb61898aadedd8359c68

That way we can reference it as a stable build in our deps.

I'm sure the new merges can be tagged as 4.2.0 or so.

@michael-milette
Copy link
Contributor

Hi @kngai ,

What are some of the issues you've been experiencing?

Best regards,

Michael

@kngai
Copy link
Contributor Author

kngai commented Dec 17, 2015

Hi @michael-milette ,

Hard to pin point as I didn't spend much time looking through it, but it affected our home page (empty page, cut off somewhere in the head) and splash page (missing the bootstrap look).

Might be something related to the changes made in the inc or one of the head-*.php files. We're using a custom Makefile that looks for certain keywords and changes some of the php files on the fly that helps consolidate and fix some things on our end; keeps things lean.

We made a fix on our end which will incorporate this exact build (ie. before all the new merges): https://github.com/wet-boew/wet-boew-php/tree/d2d1d993da86b9aa1b2afb61898aadedd8359c68

So overall, this is just more of a release management issue than a code related one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants