Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Customizable Option for BODY Tag #77

Open
michael-milette opened this issue Jan 16, 2014 · 1 comment
Open

New Customizable Option for BODY Tag #77

michael-milette opened this issue Jan 16, 2014 · 1 comment

Comments

@michael-milette
Copy link
Contributor

Would it also be possible to add another new variables that would be a placeholder for extra parameters in the tag found in dist-php\inc\head-hav.php?

It would be added just before the initial php closing tag (around line 27):

$_PAGE['bodytag'] = (!isset($_PAGE['bodytag']) ? "" : $_PAGE['bodytag']);

And then in the body tag a few lines down:

  <body vocab="http://schema.org/" typeof="WebPage"<?php echo ' '.$_PAGE['bodytag']; ?>>

The reason for this is because applications, such as the one I work with, sometimes require class and id parameters to be added to the body tag. So far I've been using JavaScript to add them in order to make the application work. I would much rather just be able to set a $_PAGE['bodytag'] variable in order to correctly configure the body tag. The syntax above will help ensure that there is no impact if the $_PAGE['bodytag'] is not set.

Unfortunately (or maybe fortunately?) I am in a spot where I am not to modify the application core code nor the WET core code so as to ensure easy maintenance and support from both communities. While I enjoy the challenge most of the time, that leaves me with the options of customizing the application's theme or creating application plugins (which results in some pretty creative coding at times).

I realize that this request addresses one persons needs but I would imagine that other PHP based web applications might have the similar requirements.

Best regards,

Michael Milette

@michael-milette michael-milette mentioned this issue Jan 16, 2014
Merged
@upsonp
Copy link
Member

upsonp commented Mar 14, 2014

Added this in, along with variable documentation in the wiki, will be available with the next merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants