fix: do not include log option details in Docker logs

...to prevent unexpected content to appear in the logs when interpreting the agent output.
wetransform-os · Jan 13, 2025 · 50c40e1 · 50c40e1
1 parent fea7057
commit 50c40e1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/orchestrators/docker.go b/pkg/orchestrators/docker.go
@@ -172,7 +172,7 @@ func (o *DockerOrchestrator) DeployAgent(image string, cmd []string, envs []stri
 	body, err := o.client.ContainerLogs(context.Background(), container.ID, types.ContainerLogsOptions{
 		ShowStdout: true,
 		ShowStderr: true,
-		Details:    true,
+		Details:    false,
 		Follow:     true,
 	})
 	if err != nil {
@@ -363,7 +363,7 @@ func (o *DockerOrchestrator) AttachOrphanAgent(containerID, namespace string) (s
 	body, err := o.client.ContainerLogs(context.Background(), container.ID, types.ContainerLogsOptions{
 		ShowStdout: true,
 		ShowStderr: true,
-		Details:    true,
+		Details:    false,
 		Follow:     true,
 	})
 	if err != nil {

diff --git a/pkg/orchestrators/docker_test.go b/pkg/orchestrators/docker_test.go
@@ -237,7 +237,7 @@ func TestDockerDeployAgentSuccess(t *testing.T) {
 	mockDocker.EXPECT().ContainerLogs(context.Background(), "alpha", types.ContainerLogsOptions{
 		ShowStdout: true,
 		ShowStderr: true,
-		Details:    true,
+		Details:    false,
 		Follow:     true,
 	}).Return(ioutil.NopCloser(bytes.NewReader([]byte("foo"))), nil).Times(1)