Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: GeoTools update 29.1 #3

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

emanuelaepure10
Copy link

Update GeoTools from 21.0 to 29.1
Update gradle from 7.5.1 to 8.4

ING-4083

@emanuelaepure10 emanuelaepure10 force-pushed the build/ING-4083 branch 2 times, most recently from 163138e to 1d17351 Compare December 7, 2023 23:15
@emanuelaepure10 emanuelaepure10 changed the title build: GeoTools update build: GeoTools update 29.1 Dec 7, 2023
@emanuelaepure10 emanuelaepure10 force-pushed the build/ING-4083 branch 2 times, most recently from e5c186b to 27bfbb0 Compare December 7, 2023 23:32
@emanuelaepure10
Copy link
Author

@stempler The test successfully passes when executed locally. Any insights on why it fails in this environment?

@stempler
Copy link
Member

stempler commented Dec 8, 2023

@emanuelaepure10 If you look at the build logs you can see there is a compilation error:

> Task :compileJava FAILED
/home/runner/work/topojson-j/topojson-j/src/json/topojson/api/TopojsonApi.java:16: error: cannot access org.opengis.referencing.crs.CoordinateReferenceSystem
import org.opengis.referencing.crs.CoordinateReferenceSystem;
                                  ^
2 actionable tasks: 1 executed, 1 up-to-date
  bad class file: /home/runner/.gradle/caches/modules-2/files-2.1/org.geotools/gt-opengis/29.1/5e33741d1b75e87f2c8154[21](https://github.com/wetransform-os/topojson-j/actions/runs/7135273191/job/19431711153?pr=3#step:8:22)79e2c16dae4579fd/gt-opengis-29.1.jar(org/opengis/referencing/crs/CoordinateReferenceSystem.class)
    class file has wrong version 55.0, should be 52.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.

It seems the build requires a newer Java version than 8, which is configured in both CI workflows.

@emanuelaepure10
Copy link
Author

Following the successful merging of these changes, the subsequent steps are as follows:

  1. Re-run hale-platform to incorporate the updated version.
  2. Integrate the modifications into my fork, hale-build-support.
  3. Verify the impact of the changes on hale studio.

@emanuelaepure10
Copy link
Author

I would like to complete the GeoTools update task soon...today :-) if possible
Could one of you @stempler @florianesser please check it.
Thank you in advance

Update GeoTools from 21.0 to 29.1
Update gradle from 7.5.1 to 8.4

ING-4083

update
@stempler stempler merged commit 206fa0d into wetransform-os:master Dec 12, 2023
Copy link

we-release bot commented Aug 15, 2024

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@we-release we-release bot added the released label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants