Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block in Vat.Embargo until host unregisters all stream handlers #45

Open
lthibault opened this issue Aug 19, 2022 · 0 comments
Open

Block in Vat.Embargo until host unregisters all stream handlers #45

lthibault opened this issue Aug 19, 2022 · 0 comments
Labels

Comments

@lthibault
Copy link
Contributor

Vat.Embargo is used to remove a capability from the vat. Callers should be able to know exactly when this operation succeeds, so that they can reason about access revocation. Unfortunately, libp2p's Host.RemoveStreamHandler is asynchronous, so it is often the case that Embargo returns before the stream handler is actually disabled.

Two approaches to investigate:

  • Is there a signal on event.Bus that we can wait for?
  • Is there a network.Notifiee hook that we can tap into?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant