Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate naming of LinearPSMDataset OnDiskPSMDataset #122

Open
gessulat opened this issue Aug 1, 2024 · 1 comment
Open

Consolidate naming of LinearPSMDataset OnDiskPSMDataset #122

gessulat opened this issue Aug 1, 2024 · 1 comment

Comments

@gessulat
Copy link
Contributor

gessulat commented Aug 1, 2024

This issue stems from this discussion.

MSAID's streaming branch introduces the OnDiskPSMDataset class which is enables the chunk-wise streaming of a PSMDataset and returns this chunks as LinearPSMDataset. To make this relationship more explicit and clearer to developers it would be nice to consolidate the names. For example InMemoryPSMDataset and OnDiskPSMDataset.
@gessulat gessulat mentioned this issue Aug 1, 2024
Merged
@jspaezp
Copy link
Collaborator

jspaezp commented Dec 6, 2024

I think this was done in #127 / #128 right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gessulat @jspaezp