Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make application responsive #337

Closed
rolandgeider opened this issue Sep 28, 2016 · 3 comments
Closed

Make application responsive #337

rolandgeider opened this issue Sep 28, 2016 · 3 comments
Milestone

Comments

@rolandgeider
Copy link
Member

rolandgeider commented Sep 28, 2016

The django-mobile application is currently not compatible with django 1.10 and seems to be slowly discontinued. While there is a workaround for this specific problem (see gregmuellegger/django-mobile#72), this would be a good opportunity to make our application truly responsive and not depend on browser sniffing or such (even more considering that bootstrap provides many helpers for this).

There are currently two templates for a couple of pages, a regular one and a mobile one. The mobile template is in a subfolder called "mobile", e.g.manager/templates/mobile/workout/view.html vs manager/templates/workout/view.html. These need to be adapted, deciding in a case by case base how to do it (make both the same, hide some navigation elements for certain sizes, etc.). There is also one instance where we check for in python code (set.py), otherwise just search "flavour".

@rolandgeider rolandgeider added this to the 1.9 milestone Feb 22, 2017
@rolandgeider
Copy link
Member Author

Definitely something to do for 1.9

@rolandgeider rolandgeider modified the milestones: 1.9, 2.0 Jun 10, 2020
@rolandgeider
Copy link
Member Author

This involves removing all the ua_aware_renderer, the TEST_MOBILE variable check for thests (and the travis conf) as well

@rolandgeider
Copy link
Member Author

With the merging of feature/mobile-templates, this issue can be closed. Note, that while all hard-coded checks for user agents or similar were removed, the application is not completely optimized yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant