Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow min() and max() in <img sizes=""> #3003

Closed
zcorpan opened this issue Sep 4, 2017 · 5 comments
Closed

Allow min() and max() in <img sizes=""> #3003

zcorpan opened this issue Sep 4, 2017 · 5 comments
Labels
normative change topic: img

Comments

@zcorpan
Copy link
Member

zcorpan commented Sep 4, 2017

https://html.spec.whatwg.org/multipage/images.html#sizes-attributes

A <source-size-value> must not be negative, and must not use CSS functions other than the 'calc()' function.

See w3c/csswg-drafts@371d0a1

Related: #2973 (comment)
@tabatkins
Copy link
Contributor

Yes, it should now specify that it only allows "math functions".

@zcorpan zcorpan added the good first issue Ideal for someone new to a WHATWG standard or software project label Sep 8, 2017
@musgravejw musgravejw mentioned this issue Sep 30, 2017
Merged
@donovanglover
Copy link
Contributor

I'm going to submit a pull request soon to address this issue.

@donovanglover donovanglover mentioned this issue Feb 17, 2018
Closed
@annevk
Copy link
Member

annevk commented Feb 19, 2018

@gloverdonovan oops, we already have one: #3084. The main problem is that we don't have tests yet.

@zcorpan zcorpan removed the good first issue Ideal for someone new to a WHATWG standard or software project label Feb 19, 2018
@donovanglover
Copy link
Contributor

Haha, I just completely skipped over all the references in this issue. Is there any way I can help with the tests?

@annevk
Copy link
Member

annevk commented Feb 19, 2018

@gloverdonovan yeah, if you're interested in writing them that'd help a lot. I don't think anyone has started on them yet.

I guess some tests need to be added to https://github.com/w3c/web-platform-tests/tree/master/html/semantics/embedded-content/the-img-element/sizes at least.

@annevk annevk closed this as completed in 5d091c2 Apr 9, 2018
yutakahirano pushed a commit to yutakahirano/html that referenced this issue Apr 26, 2018
@musgravejw @yutakahirano
Allow mathematical expressions in <img sizes>
ac8f983 
Tests: web-platform-tests/wpt#10167.

Fixes whatwg#3003.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@musgravejw
Allow mathematical expressions in <img sizes>
4dc6b05 
Tests: web-platform-tests/wpt#10167.

Fixes whatwg#3003.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
normative change topic: img
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow min() and max() for the image sizes attribute
4 participants
@zcorpan @tabatkins @annevk @donovanglover