-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add domintro blocks for “Web storage” interfaces #3179
Merged
domenic
merged 13 commits into
master
from
sideshowbarker/web-storage-section-add-domintro
Dec 12, 2017
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5dc34f5
Add domintro blocks for “Web storage” interfaces
sideshowbarker 0c1067a
Use <code>Storage</code> instead of <var>s
sideshowbarker a97cb5c
Add missing period
sideshowbarker 774aa64
Streamline the domintro for Storage.setItem
sideshowbarker 3d64cce
Restore event-firing requirements to dev edition
sideshowbarker 7c36915
Restore data-expiration paragraph to dev edition
sideshowbarker 44cfce5
Include Disk Space, Privacy section in dev edition
sideshowbarker ecd5178
Add domintro for window.localStorage
sideshowbarker 269ac43
Reword in terms of “storage item” being changed
sideshowbarker 0de841a
Streamline StorageEvent attributes normative text
sideshowbarker 7932bad
Add dev-edition “send a storage notification” dfn
sideshowbarker f477a83
Respond to review comments
sideshowbarker 13cde45
Some last domintro tweaks
domenic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these operations might be clearer if phrased using https://infra.spec.whatwg.org/#maps, possibly including linking to them?
Probably that should be a follow-up for both the dev-facing docs and the normative definitions, instead of being done here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, seems so
Raised #3252