Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun tests using different MQ Size #15

Open
araskachoi opened this issue Dec 4, 2019 · 5 comments
Open

Rerun tests using different MQ Size #15

araskachoi opened this issue Dec 4, 2019 · 5 comments

Comments

@araskachoi
Copy link
Contributor

araskachoi commented Dec 4, 2019

  • edit the queue size of gossipsub
  • the value is hardcoded at 32
  • try with a queue size of 128, and with a queue size of 256

NOTE:
PL has also merged the pubsub tracer recently (libp2p/go-libp2p-pubsub#227) and created a bunch of utilities for collecting, manipulating, and inspecting traces from a network (https://github.com/libp2p/go-libp2p-pubsub-tracer)

Should perform additional runs with/without tracing, and sending the dumps over so the libp2p team can inspect them.

@araskachoi
Copy link
Contributor Author

@jasonatran the best way would be to fork go-libp2p-pubsub to make the necessary changes and pull the code into our fork of adam's code in my repo

what do you think?

@jasonatran
Copy link
Contributor

I think the tracer looks promising, so we can avoid any fork of go-libp2p-pubsub for now. We can revisit this after the first attempt to test using just the new tracer implementation. They already merged go-libp2p-pubsub/pull/227 for us.

@araskachoi
Copy link
Contributor Author

yes, but looks like that's going to require additional implementation into adam's code. for the sake of time, might be more efficient to run the tests with the changed message queue size first and then implement tracer later? or hold off on all tests until we get the tracer?

@jasonatran
Copy link
Contributor

Oh yea, I do think we should fork go-libp2p-pubsub-benchmark-tools. We have a bunch of changes coming up for tracer, so I think it'll give us more agility if we fork off. I think a single run to verify that the queue size change fixes the dropped packet will be sufficient. My gut tells me it won't change the overall statistics of the gossip tests. If there is a change, we'll see it when we start testing with tracer.

@araskachoi
Copy link
Contributor Author

will not use tracer for these tests and will move forward with using an increased messagequeuesize

https://github.com/araskachoi/go-libp2p-pubsub-benchmark-tools/blob/develop/pkg/host/host.go#L235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants