-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rerun tests using different MQ Size #15
Comments
@jasonatran the best way would be to fork go-libp2p-pubsub to make the necessary changes and pull the code into our fork of adam's code in my repo what do you think? |
I think the tracer looks promising, so we can avoid any fork of |
yes, but looks like that's going to require additional implementation into adam's code. for the sake of time, might be more efficient to run the tests with the changed message queue size first and then implement |
Oh yea, I do think we should fork |
will not use tracer for these tests and will move forward with using an increased messagequeuesize https://github.com/araskachoi/go-libp2p-pubsub-benchmark-tools/blob/develop/pkg/host/host.go#L235 |
NOTE:PL has also merged the pubsub tracer recently (libp2p/go-libp2p-pubsub#227) and created a bunch of utilities for collecting, manipulating, and inspecting traces from a network (https://github.com/libp2p/go-libp2p-pubsub-tracer)Should perform additional runs with/without tracing, and sending the dumps over so the libp2p team can inspect them.The text was updated successfully, but these errors were encountered: