Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to generate random messages of a given size #3

Open
atoulme opened this issue Sep 17, 2019 · 4 comments
Open

Add the ability to generate random messages of a given size #3

atoulme opened this issue Sep 17, 2019 · 4 comments

Comments

@atoulme
Copy link
Contributor

atoulme commented Sep 17, 2019

Allow to create random messages of a given size, with the size being given as a parameter to the function.

@adam-hanna
Copy link

Agreed.

There's a bytes array that will be used to hold this variable sized data in the message protobuf:
https://github.com/agencyenterprise/gossip-host/blob/6c5adf566b389edd47656e75a229e354c06e1e57/internal/host/pb/message.proto#L7

@araskachoi
Copy link
Contributor

@adam-hanna Hey adam, so does this create a message with indicated size (in bytes)? I'm not sure how important it is but should we make the whole message be the indicated size or should we have the message data field be the indicated size? might not matter so much right now

@adam-hanna
Copy link

adam-hanna commented Sep 25, 2019

@araskachoi

Right now, it just reads from a json file. So the json file would need to have a bytes array of the desired size.

I could really easily add flag that replaces the bytes array in the json file with one of a desired size.

I think the entire message size should be the metric we target.

@araskachoi
Copy link
Contributor

Yes I agree, the entire size of the message should be the size that we indicated.

Awesome, this will be needed when we will run the msg_size test; where we vary the message size in bytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants