Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Load Generator #9

Open
araskachoi opened this issue Sep 27, 2019 · 4 comments
Open

Message Load Generator #9

araskachoi opened this issue Sep 27, 2019 · 4 comments

Comments

@araskachoi
Copy link
Contributor

have a separate generator that will send messages

  • pass arguments for:
    • int: number_of_messages_per_second
    • arr: ip_to_send_to
@araskachoi
Copy link
Contributor Author

@adam-hanna
any comments on this? I think it will be important to separate the logic of message sending so that it is external to the client. This way we can keep the libp2p client will solely use their computational resources to relay messages, instead of sending them.

Let me know if you need more clarifications on this or have any questions!

@adam-hanna
Copy link

Yup, this has been implemented in cmd/client

Messages per second hasn't been implemented, but could be done by wrapping in a shell script or something

@araskachoi
Copy link
Contributor Author

So the implementation that you made is inside the client. In your opinion, also might need to get feedback from PL, do you think that this is the best way to implement the message load generator? This would mean that the container that is running the client will also be responsible for sending the messages. This might cause the container to have more overhead than needed? I think it would be best to separate the logic so that we can have unbiased test results. what do you think?

@araskachoi
Copy link
Contributor Author

Right, so the best way to do this would to have the client implementation send these messages. basically load the host with messages that are made inside client and pass them via RPC at a specified rate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants