Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getChildren, entityComments and entityHistorySummary should also contain entityIRI and projectId in the response #19

Closed
soimugeoWB opened this issue Nov 27, 2024 · 3 comments · Fixed by #28, protegeproject/webprotege-event-history-service#21 or #29
Closed

getChildren, entityComments and entityHistorySummary should also contain entityIRI and projectId in the response #19

soimugeoWB opened this issue Nov 27, 2024 · 3 comments · Fixed by #28, protegeproject/webprotege-event-history-service#21 or #29
Assignees
@soimugeoWB
Labels
enhancement New feature or request

Comments

@soimugeoWB
Copy link
Collaborator

As a user i want to be able to see the entityIRI and the projectId in the response of the request to better understand for which entity this response refers to.
@soimugeoWB soimugeoWB added the enhancement New feature or request label Nov 27, 2024
@soimugeoWB
Copy link
Collaborator Author

Also added validation for projectId and entityUri.

@soimugeoWB
Copy link
Collaborator Author

Image
Image
Image

soimugeoWB added a commit that referenced this issue Jan 3, 2025
@soimugeoWB
fixed #19
0409bd0
soimugeoWB added a commit to protegeproject/webprotege-event-history-service that referenced this issue Jan 3, 2025
@soimugeoWB
fix for who-icatx/icatx-api-gateway#19
f6fcbb4
@soimugeoWB soimugeoWB linked a pull request Jan 3, 2025 that will close this issue
19 getchildren entitycomments and entityhistorysummary should also contain entityiri and projectid in the response #28
Merged
@soimugeoWB soimugeoWB self-assigned this Jan 3, 2025
alexsilaghi added a commit to protegeproject/webprotege-event-history-service that referenced this issue Jan 6, 2025
@alexsilaghi
Merge pull request #21 from protegeproject/19-getchildren-entitycomme…
88ce802 
…nts-and-entityhistorysummary-should-also-contain-entityiri-and-projectid-in-the-response

fix for who-icatx/icatx-api-gateway#19
@soimugeoWB
Copy link
Collaborator Author

switch in the response to have first the projectId.

This was linked to pull requests Jan 13, 2025
fix for https://github.com/who-icatx/icatx-api-gateway/issues/19 protegeproject/webprotege-event-history-service#21
Merged
switch entityUri with projectId for getChildren and getEntityHistory #29
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soimugeoWB soimugeoWB

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@soimugeoWB