Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out unwanted Logical Definition Superclasses #123

Open
csnyulas opened this issue Oct 24, 2024 · 3 comments
Open

Filter out unwanted Logical Definition Superclasses #123

csnyulas opened this issue Oct 24, 2024 · 3 comments

Comments

@csnyulas
Copy link
Contributor

In the pop-up that appears for selecting the "Logical Definition Superclass" in the Logical Definitions view, we should filter out the classes that don't make sense to be used as a potential logical definition superclass. These could be, for example, superclasses that are NOT included in any of the linearizations (according to the Linearizations information), OR classes that are NOT descendants of any of the "relevant" "top" classes (which can be specified in some configurations, e.g. of the Class Tree view or that of the Logical Definition view).

Doing this we could get rid of irrelevant superclasses, such as ICD Entity, Classification Entities and owl:Thing.

@soimugeoWB
Copy link
Collaborator

The easiest way to filter out the unwanted classes would be to do how Csongor said and just filter out all the classes that do not have a linearization. this will also fix #127

@soimugeoWB soimugeoWB self-assigned this Nov 4, 2024
@soimugeoWB
Copy link
Collaborator

ICD Entity, Extension codes and ICF Entity seem to have a linearization history based on the import file whofic_foundation_2024.05.30_v2.lin.json.zip
. Is this correct? if yes then they will not be filtered by the current implementation.

@tudorache tag for visibility.

@tudorache
Copy link
Contributor

I suggest to leave it open a little longer, but not work on it for now. Once we figure out the right filtration, we will update the implementation.

@soimugeoWB soimugeoWB removed their assignment Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment